fix: eliminate orphan DEFERRED warning false positives (F3)#573
Merged
Muizzkolapo merged 1 commit intoMay 19, 2026
Merged
Conversation
The _warn_orphaned_deferred() query reported all records with DEFERRED disposition as orphans, even when those records had already received a terminal disposition (SUCCESS, FAILED, etc.) — the stale DEFERRED row just hadn't been cleared yet. Changed to a two-step approach: first query DEFERRED records (indexed, fast — returns 0 in the happy path). Only if deferred records exist, query terminal dispositions to filter out false positives. Genuine orphans = deferred IDs with no terminal sibling. Observed: product_listing_enrichment had 71 false orphan warnings that are now suppressed.
Muizzkolapo
force-pushed
the
fix/f3-orphan-warning-timing
branch
from
67638e4 to
7db8e37
Compare
Muizzkolapo
merged commit 292e68f
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_warn_orphaned_deferred()reported all N records as orphans after batch completion, even when they had terminal dispositions (SUCCESS, FAILED, etc.) — the stale DEFERRED row just hadn't been cleared yet. Observed on product_listing_enrichment: 71 false orphan warnings.batch.py:_warn_orphaned_deferred()only — no other files modified.Verification
ruff format --check+ruff checkclean