fix: remove prefilter_by_guard eval_item fallback (F8)#575
Merged
Muizzkolapo merged 1 commit intoMay 19, 2026
Merged
Conversation
The has_pipeline_context check in prefilter_by_guard silently fell back to context=eval_item when no pipeline kwargs were passed. All production callers already pass full context, making this a dormant anti-pattern that could reintroduce online/batch guard divergence if a future caller omitted the kwargs. Now prefilter_by_guard always calls build_guard_context unconditionally. Deleted 8 tests that asserted the old fallback behavior (context==eval_item, fallback warning). Updated the paired_execution conftest fixture to handle the richer context shape from build_guard_context.
Muizzkolapo
force-pushed
the
fix/f8-prefilter-fallback
branch
from
4743ef8 to
cc41223
Compare
Muizzkolapo
merged commit 6cbe3d6
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
has_pipeline_contextcheck andcontext = eval_itemfallback inprefilter_by_guard— now always usesbuild_guard_contextunconditionallypaired_executionconftest fixture mock to handle the richer context shape frombuild_guard_contextVerification
pytest— 7024 passed, 2 skippedruff format --check+ruff check— cleanprefilter_by_guardcallers — both production callers (_guard_filter,_guard_filter_file_mode) pass full pipeline context