chore: consolidate changie entries + tighten F1 guard tests#577
Merged
Muizzkolapo merged 2 commits intoMay 19, 2026
Merged
Conversation
Replaces 30 individual changie YAML files (one per PR) with a single consolidated entry covering the entire batch/online unification initiative (Phases 0–9) and bug fix wave (F1–F15).
- Assert len(filtered) in test_all_filtered and test_filter_removes_failing_records (would have caught the original pre-fix regression) - Log line uses len(filtered) instead of subtraction - Record-mode disposition test asserts args[2] + source_guid structurally (was string-matching with `in str(c)`) - Negative test fixes arg index: disposition is args[2], not args[3]
Muizzkolapo
merged commit 441ab94
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changie consolidation
Under the Hood-20260519-batch-online-unification.yaml)F1 review follow-ups
test_all_filteredandtest_filter_removes_failing_recordsnow assertlen(filtered)— would have caught the original pre-fix regression where filtered records vanishedpipeline_file_mode.py:406useslen(filtered)instead oflen(data) - len(passing) - len(skipped)subtractionc.args[2] == DISPOSITION_FILTEREDandc.args[1] == "sg-filter"structurally (wasDISPOSITION_FILTERED in str(c))args[2]notargs[3]Verification
pytest— 7024 passed, 2 skippedruff format --check+ruff check— cleanyaml.safe_load()— valid structure and timestamp