fix: resolve mypy type errors in batch manager and submission#579
Merged
Muizzkolapo merged 1 commit intoMay 19, 2026
Merged
Conversation
- batch.py:206 — guard None rid before adding to set[str] - submission.py:295 — early return when storage_backend is None
Muizzkolapo
merged commit 5431cab
into
integration/batch-online-unification
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batch.py:206—ridfromr.get("record_id")isAny | None; guard None beforeset.add(str)submission.py:295—self._storage_backendisAny | None; early return when None before passing to_safe_set_dispositionFixes CI mypy failures blocking the integration → main merge.
Verification
uv run mypypasses on both files