Skip to content

refactor: move admin controller to user controller#162

Merged
aayushchugh merged 3 commits intoMultiEmail:mainfrom
YashJain2409:main
Oct 26, 2022
Merged

refactor: move admin controller to user controller#162
aayushchugh merged 3 commits intoMultiEmail:mainfrom
YashJain2409:main

Conversation

@YashJain2409
Copy link
Copy Markdown
Contributor

Description

move admin.controller.ts to user.controller.ts

resolves #160

Copy link
Copy Markdown
Member

@aayushchugh aayushchugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YashJain2409 have you updated import in admin.routes.ts?

@YashJain2409
Copy link
Copy Markdown
Contributor Author

yes

@aayushchugh aayushchugh added refactor Refactor the code hacktoberfest-accepted this pulls request is merged as part of hacktoberfest labels Oct 26, 2022
@aayushchugh aayushchugh added this to the v1.0.0 milestone Oct 26, 2022
@aayushchugh
Copy link
Copy Markdown
Member

@YashJain2409 I can't see admin.routes.ts file changed

image

@YashJain2409
Copy link
Copy Markdown
Contributor Author

is it ok now ?

@aayushchugh
Copy link
Copy Markdown
Member

@YashJain2409 please edit the PR title and follow conventional commits

Comment thread src/routes/admin.routes.ts Outdated
Comment thread src/controllers/user.controller.ts Outdated
Comment thread src/controllers/user.controller.ts Outdated
@YashJain2409 YashJain2409 changed the title move admin controller to user controller refactor: move admin controller to user controller Oct 26, 2022
@YashJain2409
Copy link
Copy Markdown
Contributor Author

is it correct now ?

@aayushchugh aayushchugh requested a review from tharun634 October 26, 2022 13:55
@aayushchugh aayushchugh merged commit b1613cc into MultiEmail:main Oct 26, 2022
@aayushchugh
Copy link
Copy Markdown
Member

@all-contributors please add @YashJain2409 for code

@allcontributors
Copy link
Copy Markdown
Contributor

@aayushchugh

I've put up a pull request to add @YashJain2409! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted this pulls request is merged as part of hacktoberfest refactor Refactor the code

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[REFACTOR] ♻️ rename admin.controller.ts to user.controller.ts

3 participants