-
Notifications
You must be signed in to change notification settings - Fork 44
Scrub User Agent #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scrub User Agent #45
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bfad444
feat: scrub user agent
iamEvanYT bca0975
feat: enable scrubbing
iamEvanYT 736eb06
feat: add comments
iamEvanYT f283abb
feat: add edge
iamEvanYT 02a5eea
feat: spotify & google accounts work
iamEvanYT 4910820
feat: intergrated user agent transformer
iamEvanYT c8ce07a
chore: remove polyfilled navigator.userAgentData
iamEvanYT f7fcf4c
remove: edge user agent
iamEvanYT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { FLAGS } from "@/modules/flags"; | ||
| import { app } from "electron"; | ||
|
|
||
| const EDGE_USER_AGENT = "Edg/136.0.3240.76"; | ||
|
|
||
| export function transformUserAgentHeader(userAgent: string, url: URL | null) { | ||
| if (!FLAGS.SCRUBBED_USER_AGENT) { | ||
| return userAgent; | ||
| } | ||
|
|
||
| // Edge User Agent: | ||
| // - Causes a few issues with Google Auth | ||
| const addEdgeUserAgent = false; | ||
|
|
||
| // Remove Electron User Agent: | ||
| // - Causes issues with Spotify | ||
| const removeElectronUserAgent = true; | ||
|
|
||
| // Remove App User Agent: | ||
| // - Flow will be less identifiable | ||
| const removeAppUserAgent = false; | ||
|
|
||
| if (url) { | ||
| // const hostname = url.hostname.toLowerCase(); | ||
| // if (hostname === "accounts.google.com") { | ||
| // } | ||
| } | ||
|
|
||
| if (removeElectronUserAgent) { | ||
| userAgent = userAgent.replace(/\sElectron\/\S+/, ""); | ||
| } | ||
|
|
||
| if (removeAppUserAgent) { | ||
| const appName = app.getName(); | ||
| userAgent = userAgent.replace(new RegExp(`\\s${appName}/\\S+`, "i"), ""); | ||
| } | ||
|
|
||
| const hasEdgeUserAgent = userAgent.includes(EDGE_USER_AGENT); | ||
| if (addEdgeUserAgent && !hasEdgeUserAgent) { | ||
| userAgent = `${userAgent} ${EDGE_USER_AGENT}`; | ||
| } | ||
|
|
||
| return userAgent; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.