[Fix] bbox_nms function #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi, Thank you for your pull request! That was indeed a mistake on my part, and I will merge this PR as soon as possible. However, could you please submit your PR to the DEPLOY branch instead of the main branch? Thank you! Best regards, |
f-fl0
force-pushed
the
fix-bbox-nms-function
branch
from
d8b6bf4 to
7335a2e
Compare
Contributor
Author
|
Thank you @henrytsui000. I rebased my PR on the |
yjmm10
pushed a commit
to yjmm10/YOLO-MIT
that referenced
this pull request
Aug 28, 2024
2. optimize the program for calculating AP and support more AP index 3. fix the choice of mode
yjmm10
pushed a commit
to yjmm10/YOLO-MIT
that referenced
this pull request
Aug 28, 2024
add: more test_calculate_map case
mapo80
pushed a commit
to mapo80/YOLO
that referenced
this pull request
Jan 4, 2026
* Use valid_con instead of valid_cls in batched_nms * Update test_bbox_nms * Improve comments * Apply black
mapo80
pushed a commit
to mapo80/YOLO
that referenced
this pull request
Jan 4, 2026
* Use valid_con instead of valid_cls in batched_nms * Update test_bbox_nms * Improve comments * Apply black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the documentation of batched_nms, the second argument should the
scores for each one of the boxesbut in the current implementationvalid_clsis used which is a tensor of class indexes. I believevalid_conshould be used instead. I tried to update the tests to exhibit the issue.Type of Change
Bug fix (non-breaking change which fixes an issue)
Checklist:
Licensing:
By submitting this pull request, I confirm that: