Skip to content

Extrapolation to calo surface#20

Merged
pandreetto merged 5 commits intoMuonColliderSoft:mainfrom
madbaron:calosurface
Jul 12, 2024
Merged

Extrapolation to calo surface#20
pandreetto merged 5 commits intoMuonColliderSoft:mainfrom
madbaron:calosurface

Conversation

@madbaron
Copy link
Copy Markdown
Contributor

This PR adds the extrapolation of the tracks to the calorimeter surface.

This is still work in progress:

  • the code compiles
  • the addition of the track state at the calorimeter surface to the track is still missing
  • crashes at run time on the call to the propagator with a "TUnixSystem::Di... FATAL segmentation violation"

I am creating this ahead of time since I'll have now a couple of busy days, in case superexperts like @kkrizka @spagangriso or @pandreetto get a chance to take a look.

@madbaron
Copy link
Copy Markdown
Contributor Author

Note to self: I think once the propagator crash is solved, the extrapolation should probably be moved to ACTS2Marlin_track inside Helpers.cxx

@madbaron
Copy link
Copy Markdown
Contributor Author

Moved to Helpers.cxx.
This also fixed the crash at runtime.
Still missing the saving of the TrackState - coming soon.

@madbaron
Copy link
Copy Markdown
Contributor Author

Ok great success so far.
The extrapolation works and the states at the calorimeter face are compatible with those from the Refit processor.

One last thing missing: the cylindrical volume has no caps, so the forward tracks are still missing the extrapolation

@madbaron madbaron changed the title WIP: Attempt at adding extrapolation to calo surface Extrapolation to calo surface Jul 10, 2024
@madbaron
Copy link
Copy Markdown
Contributor Author

madbaron commented Jul 10, 2024

All good, ready to merge.

In the future / next release we'll want to:

  • start the extrapolation from the last spacepoint instead of the perigee
  • add extrapolation to muon system

Both these are not urgent for this release

@pandreetto pandreetto merged commit c197992 into MuonColliderSoft:main Jul 12, 2024
@madbaron madbaron deleted the calosurface branch July 15, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants