Extrapolation to calo surface#20
Merged
pandreetto merged 5 commits intoMuonColliderSoft:mainfrom Jul 12, 2024
madbaron:calosurface
Merged
Extrapolation to calo surface#20pandreetto merged 5 commits intoMuonColliderSoft:mainfrom madbaron:calosurface
pandreetto merged 5 commits intoMuonColliderSoft:mainfrom
madbaron:calosurface
Conversation
Contributor
Author
|
Note to self: I think once the propagator crash is solved, the extrapolation should probably be moved to ACTS2Marlin_track inside Helpers.cxx |
Contributor
Author
|
Moved to Helpers.cxx. |
Contributor
Author
|
Ok great success so far. One last thing missing: the cylindrical volume has no caps, so the forward tracks are still missing the extrapolation |
Contributor
Author
|
All good, ready to merge. In the future / next release we'll want to:
Both these are not urgent for this release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the extrapolation of the tracks to the calorimeter surface.
This is still work in progress:
I am creating this ahead of time since I'll have now a couple of busy days, in case superexperts like @kkrizka @spagangriso or @pandreetto get a chance to take a look.