Loading of layer description from JSON.#22
Merged
pandreetto merged 1 commit intomainfrom Sep 2, 2024
Merged
Conversation
Contributor
Author
|
@davzuliani This is a step towards making it possible to include your new tracking layout in a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description of the tracking detector volumes and layers is now moved to an external JSON file instead of being hardcoded to the
MuColl_v1geometry. The format of the JSON file is the same as used by the ACTS TGeo example as the ACTSMCC instructions for generating material maps.The processors that use the geometry now take a
TGeoDescFileattribute with the path to the JSON file. For backwards compatibility, the default is set to the newly includeddata/MuColl_v1.json.This does not remove all hardcoded dependence on
MuColl_v1as the mapping tool (GeometryIdMappingTool) still needs to be configurable.