Fix particle hypothesis having to be positive in truth tracking.#23
Merged
Fix particle hypothesis having to be positive in truth tracking.#23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the truth-based tracking (either full truth or truth ckf) fail with the following error:
Appears that ACTS requires the particle hypothesis to always correspond to original (? not anti-) variation of the particle. This fixes it by taking the absolute value of the
MCParticlePDG before creating the hypothesis.The
convertParticlefunction has been renamed togetParticleHypothesisto indicate that this is no longer a simple event data model conversion. The PDG ID does change.