Switching couts to streamlogs#28
Switching couts to streamlogs#28madbaron merged 2 commits intoMuonColliderSoft:mainfrom madbaron:silence_couts
Conversation
|
This should be a trivial change, but @pandreetto could you take a look and sign off if you're happy? |
|
Adding a couple more reviewers to help move this along |
| } | ||
| else{ | ||
| std::cout << "Failed propagation! " << std::endl; | ||
| streamlog_out(MESSAGE) << "Failed propagation! " << std::endl; |
There was a problem hiding this comment.
Is MESSAGE the correct level here? Resp. how often does this happen? Simply from the message content I would have said that this sounds like some non-fatal but also not too common occurrence and that WARNING might be more appropriate? But I don't know enough of the details.
There was a problem hiding this comment.
Our events are dominated by fake seeds from BIB, so we would get this message a few thousand times per event
There was a problem hiding this comment.
Right, in that case DEBUG might be the better option since you probably don't want to produce GBs of logfiles. (However in that case it should be pointed out that the possibility of turning that on at runtime depends on how Marlin was built, so it might not be easily possible to make these messages appear).
2 participants
This PR silences a couple of couts, moving to streamlogs