Skip to content

protections against missing objects#29

Merged
madbaron merged 1 commit intoMuonColliderSoft:mainfrom
madbaron:matching_fix
Dec 10, 2024
Merged

protections against missing objects#29
madbaron merged 1 commit intoMuonColliderSoft:mainfrom
madbaron:matching_fix

Conversation

@madbaron
Copy link
Copy Markdown
Contributor

@madbaron madbaron commented Dec 9, 2024

This PR implements a couple of protections against missing collections and pointers in slimmed slcio files

@madbaron madbaron requested a review from tmadlener December 9, 2024 15:39
Copy link
Copy Markdown

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

At least for the ILD reconstruction we have started to try and eliminate all of the cases where missing collections might indicate an empty collection, and instead made all processors fill empty collections in case they haven't produced any output. The main reason is that a missing collection can otherwise mean missing because empty or it could also be a misconfiguration.

To make for an easier transition we have also implemented a PatchCollection processor, e.g. here: https://github.com/iLCSoft/ILDConfig/blob/fb10b66cdc2335d8f84443a14ec7fda64ab389ed/StandardConfig/production/ILDReconstruction.py#L322-L329 that can create missing empty collections on the fly if they should be present. The configuration is pairs of strings, following this description

@madbaron madbaron merged commit ce74f55 into MuonColliderSoft:main Dec 10, 2024
@madbaron madbaron deleted the matching_fix branch December 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants