Skip to content

add units to calo faces #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madbaron merged 1 commit into from
Jun 18, 2025
Merged

add units to calo faces #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Helpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,16 +301,16 @@ EVENT::Track* ACTS2Marlin_track(
}

// Create the CaloSurface
auto caloCylinder = std::make_shared<Acts::CylinderBounds>(caloFaceR, caloFaceZ);
auto caloCylinder = std::make_shared<Acts::CylinderBounds>(caloFaceR * Acts::UnitConstants::mm, caloFaceZ * Acts::UnitConstants::mm);
auto caloSurface = Acts::Surface::makeShared<Acts::CylinderSurface>(Acts::Transform3::Identity(), caloCylinder);

// Define the circle dimensions (circles at both ends of the cylinder)
Acts::Translation3 circlePosition1(0, 0, -caloFaceZ); // circle at -z end
Acts::Translation3 circlePosition2(0, 0, caloFaceZ); // circle at +z end
Acts::Translation3 circlePosition1(0, 0, -caloFaceZ * Acts::UnitConstants::mm); // circle at -z end
Acts::Translation3 circlePosition2(0, 0, caloFaceZ * Acts::UnitConstants::mm); // circle at +z end

// Create the circle surfaces
auto circleSurface1 = Acts::Surface::makeShared<Acts::DiscSurface>(Acts::Transform3(circlePosition1), 0. ,caloFaceR);
auto circleSurface2 = Acts::Surface::makeShared<Acts::DiscSurface>(Acts::Transform3(circlePosition2), 0., caloFaceR);
auto circleSurface1 = Acts::Surface::makeShared<Acts::DiscSurface>(Acts::Transform3(circlePosition1), 0. ,caloFaceR * Acts::UnitConstants::mm);
auto circleSurface2 = Acts::Surface::makeShared<Acts::DiscSurface>(Acts::Transform3(circlePosition2), 0., caloFaceR * Acts::UnitConstants::mm);

// define start parameters - swap this out with some smart call
double d0 = params[Acts::eBoundLoc0];
Expand Down