Text to speech #20

Mushmou · 2023-08-01T21:38:23Z

No description provided.

Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

* finalized main.py --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

* Fixed test main * Working version of Text To Speech --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

* Fixed test main * Working version of Text To Speech * Deleted aws sandbox dir * made a working version of google test and fixed run commands in req.txt * Working version of azure and google, made change to readme, removed azure from req --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

* Fixed test main * Working version of Text To Speech * Deleted aws sandbox dir * made a working version of google test and fixed run commands in req.txt * Working version of azure and google, made change to readme, removed azure from req * removed test file and added ok check for main.py * working version of main.py and updated a test in testmain for aws --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

All 3 providers working in main.py, only missing azure test now.

* Fixed test main * Working version of Text To Speech * Deleted aws sandbox dir * made a working version of google test and fixed run commands in req.txt * Working version of azure and google, made change to readme, removed azure from req * removed test file and added ok check for main.py * working version of main.py and updated a test in testmain for aws * All three services working in main.py and fixed key error in test main * Finished test in unittest * fixed a small space --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local> Co-authored-by: Noah Jacinto <noahjacinto@Noahs-Air.fios-router.home>

fixed linting errors main.py

* Fixed test main * Working version of Text To Speech * Deleted aws sandbox dir * made a working version of google test and fixed run commands in req.txt * Working version of azure and google, made change to readme, removed azure from req * removed test file and added ok check for main.py * working version of main.py and updated a test in testmain for aws * All three services working in main.py and fixed key error in test main * Finished test in unittest * fixed a small space * finished test main --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local> Co-authored-by: Noah Jacinto <noahjacinto@Noahs-Air.fios-router.home>

python/text-to-speech/.gitignore

IsaacG · 2023-08-01T21:44:57Z

python/text-to-speech/README.md

+
+Your function is now listening on port `3000`, and you can execute it by sending `POST` request with appropriate authorization headers. To learn more about runtime, you can visit Python runtime [README](https://github.com/open-runtimes/open-runtimes/tree/main/runtimes/python-3.10).
+
+## 📝 Notes


I'm assuming the README is still a TODO?

Yes we are working on this.

python/text-to-speech/main.py

python/text-to-speech/test_main.py

IsaacG · 2023-08-01T22:04:50Z

python/text-to-speech/test_main.py

+    def test_speech_invalid_credential(self) -> None:
+        """Test credentials for speech method."""
+        instance = self.get_azure_instance("WRONG_API_KEY", "WRONG_PROJECT_ID")
+        # Mock the requests.post method used in get_token.


Try to avoid the temptation to write comments which says the same thing as the code.

Comments are great for explaining why you are doing something or for explaining complicated code. For simple code, though, don't add comments which just repeat the code.

python/text-to-speech/test_main.py

IsaacG · 2023-08-01T22:06:08Z

python/text-to-speech/test_main.py

+    def get_req(self, payload: str, variables: str, provider: str, text: str,
+                language: str) -> None:


Suggested change

def get_req(self, payload: str, variables: str, provider: str, text: str,

language: str) -> None:

def get_req(

self,

payload: str,

variables: str,

provider: str,

text: str,

language: str,

) -> None:

Are you using all of these arguments?

Yes, we did use all the args in the parameter.

python/text-to-speech/test_main.py

…TextToSpeech

IsaacG · 2023-08-02T06:12:55Z

python/.gitignore

Did you intend to remove this file?

Yes we intend to remove .gitignore

We cannot remove it now because every time we run the code, py_cache is generated. When we are done with testing and preparing to make a pull request, we can remove the .gitignore.

It looks like you removed the repo-wide python/.gitignore file and added a custom python/text-to-speech/,gitignore file. You probably should not remove the former. Edits to that file should be out of scope for this PR.

You should be able to git commit without using the --all flag and specifying which files are or are not included in a commit.

python/text-to-speech/main.py

IsaacG · 2023-08-02T06:15:38Z

python/text-to-speech/main.py

+        """
+        # Endpoint for cognitive services speech api
+        url = (
+            f"https://{Azure.REGION}.tts."


Suggested change

f"https://{Azure.REGION}.tts."

f"https://{self.REGION}.tts."

Could you please explain the difference between the two?

Say someone decided to implement an AzureAsia class ... which is exactly like Azure except it uses a different region.

class AzureAsia(Azure): REGION = "asia"

If you read the region from self.REGION then the AzureAsia class will read the correct region. However, if you're reading the Azure.REGION then the updated REGION value will be ignored.

python/text-to-speech/test_main.py

IsaacG · 2023-08-02T06:19:27Z

python/text-to-speech/test_main.py

+            # Raise Exception.
+            mock_synthesize_speech.side_effect = Exception
+        # Assert the raise.
+        self.assertRaises(Exception, instance.speech, "hello", "en-EN")


Should the instance.speech call be inside the mock context?

I didnt notice we can remove the instance.speech, I thought we had to keep the function and its params but I removed it. The change only includes the patch with raise exception.

Update we changed the code again.

def test_speech_invalid_language(self) -> None: """Test language for speech method.""" # Set up mock. instance = self.get_google_instance("123", "123") with mock.patch.object( texttospeech.TextToSpeechClient, "synthesize_speech" ) as mock_synthesize_speech: # Raise Exception. mock_synthesize_speech.side_effect = Exception # Assert the raise. self.assertRaises(Exception, instance.speech, "hello", "en-EN")

How does this look?

Better :) This code calls speech() with a mocked client, which I believe was the intent.

python/text-to-speech/test_main.py

* Fixed test main * Working version of Text To Speech * Deleted aws sandbox dir * made a working version of google test and fixed run commands in req.txt * Working version of azure and google, made change to readme, removed azure from req * removed test file and added ok check for main.py * working version of main.py and updated a test in testmain for aws * All three services working in main.py and fixed key error in test main * Finished test in unittest * fixed a small space * finished test main --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local> Co-authored-by: Noah Jacinto <noahjacinto@Noahs-Air.fios-router.home>

* Fixed test main * Working version of Text To Speech * Deleted aws sandbox dir * made a working version of google test and fixed run commands in req.txt * Working version of azure and google, made change to readme, removed azure from req * removed test file and added ok check for main.py * working version of main.py and updated a test in testmain for aws * All three services working in main.py and fixed key error in test main * Finished test in unittest * fixed a small space * finished test main * added the changes from PR #20 --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local> Co-authored-by: Noah Jacinto <noahjacinto@Noahs-Air.fios-router.home>

IsaacG · 2023-08-03T03:26:21Z

python/.gitignore

It looks like you removed the repo-wide python/.gitignore file and added a custom python/text-to-speech/,gitignore file. You probably should not remove the former. Edits to that file should be out of scope for this PR.

You should be able to git commit without using the --all flag and specifying which files are or are not included in a commit.

python/text-to-speech/main.py

IsaacG · 2023-08-03T03:32:00Z

python/text-to-speech/test_main.py

+            # Raise Exception.
+            mock_client.side_effect = Exception
+        # Assert the raise.
+        self.assertRaises(Exception, instance.speech, None, "en-US")


Does this call the speech() function with a mocked or real client?

I think we were supposed to put the assert raise with the with block, so it can be part of the mocked client.

IsaacG · 2023-08-03T03:36:48Z

python/text-to-speech/main.py

+        """
+        # Endpoint for cognitive services speech api
+        url = (
+            f"https://{Azure.REGION}.tts."


Say someone decided to implement an AzureAsia class ... which is exactly like Azure except it uses a different region.

class AzureAsia(Azure): REGION = "asia"

If you read the region from self.REGION then the AzureAsia class will read the correct region. However, if you're reading the Azure.REGION then the updated REGION value will be ignored.

IsaacG · 2023-08-03T03:37:31Z

python/text-to-speech/test_main.py

+            # Raise Exception.
+            mock_synthesize_speech.side_effect = Exception
+        # Assert the raise.
+        self.assertRaises(Exception, instance.speech, "hello", "en-EN")


Better :) This code calls speech() with a mocked client, which I believe was the intent.

modified main.py

IsaacG · 2023-08-03T18:21:02Z

python/.gitignore

 #  and can be added to the global gitignore or merged into this file.  For a more nuclear
 #  option (not recommended) you can uncomment the following to ignore the entire idea folder.
-#.idea/
+#.idea/


This file should not be changing as part of this PR

Our plan is to add the changes to a new branch called feat 4122 text to speech branch, it would fix this I assume.

When we create the feat-4155 with only one commit, we will double-check to ensure that changes in this file do not appear.

IsaacG · 2023-08-03T18:21:25Z

python/text-to-speech/README.md

+```json
+{
+    "success":false,
+    "error":"Missing API_KEY""


GitHub highlighting is telling me this is invalid JSON

Okay we fixed the extra quote on README.md

IsaacG · 2023-08-03T18:22:58Z

python/text-to-speech/main.py

+        polly_client = boto3.Session(
+            aws_access_key_id=self.api_key,
+            aws_secret_access_key=self.secret_api_key,
+            region_name=self.REGION).client("polly")


Suggested change

region_name=self.REGION).client("polly")

region_name=self.REGION,

).client("polly")

I fixed this one.

IsaacG · 2023-08-03T18:23:22Z

python/text-to-speech/main.py

+            provider_class = Google(req)
+        elif provider == "azure":
+            provider_class = Azure(req)
+        else:


Do you want to check the provider string here?

We already check if the provider is in the list of Supported_providers in the validate_common function (line 241 - 243).

IsaacG · 2023-08-03T18:23:49Z

python/text-to-speech/test_main.py

+    def __init__(
+            self,
+            data: dict[dict[str, str, str], dict[str, str]],
+            ) -> None:


Suggested change

) -> None:

) -> None:

Okay we fixed this one.

modified main

fix gitignore.

fixed main

test

rubynguyen1510 and others added 15 commits July 27, 2023 15:54

Implement Text To Speech base

cfccf90

added unit test aws

252f56c

Fixed test main (#10)

fb4f90e

Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

New main.py (#11)

d3e31aa

* finalized main.py --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

Noah (#12)

e6d2c71

* Fixed test main * Working version of Text To Speech --------- Co-authored-by: Noah Jacinto <noahjacinto@Noahs-MacBook-Air.local>

added unit tests for AWS and validate_common

b082a75

added unit tests for AWS and validate_common (#13)

abb1034

Resolvved merge conflicts

79487b3

Noah (#16)

7130c03

All 3 providers working in main.py, only missing azure test now.

Ngoc (#18)

31b56da

fixed linting errors main.py

Fixed azure bug

2f6fab7

Mushmou assigned IsaacG Aug 1, 2023

IsaacG requested changes Aug 1, 2023

View reviewed changes

rubynguyen1510 added 2 commits August 1, 2023 22:19

Merge remote-tracking branch 'refs/remotes/origin/TextToSpeech' into …

5040d45

…TextToSpeech

Changes after code review

680cb22

IsaacG reviewed Aug 2, 2023

View reviewed changes

Mushmou assigned rubynguyen1510 Aug 2, 2023

Mushmou requested a review from rubynguyen1510 August 2, 2023 21:41

Mushmou pushed a commit that referenced this pull request Aug 2, 2023

added the changes from PR #20

9611d1a

IsaacG reviewed Aug 3, 2023

View reviewed changes

Noah (#26)

b454c2b

modified main.py

IsaacG reviewed Aug 3, 2023

View reviewed changes

Mushmou added 2 commits August 3, 2023 11:50

Noah (#27)

622939c

modified main

Noah (#29)

0bf5f59

fix gitignore.

Mushmou added 2 commits August 3, 2023 15:29

Noah (#31)

aa6f244

fixed main

Noah (#33)

73a7a23

test

IsaacG closed this Oct 28, 2025


		Your function is now listening on port `3000`, and you can execute it by sending `POST` request with appropriate authorization headers. To learn more about runtime, you can visit Python runtime [README](https://github.com/open-runtimes/open-runtimes/tree/main/runtimes/python-3.10).

		## 📝 Notes

		def get_req(self, payload: str, variables: str, provider: str, text: str,
		language: str) -> None:

	region_name=self.REGION).client("polly")
	region_name=self.REGION,
	).client("polly")

Text to speech #20

Text to speech #20

Uh oh!

Conversation

Mushmou commented Aug 1, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment