This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Static Channel Backups#607
Merged
Merged
Conversation
benthecarman
force-pushed
the
scb
branch
3 times, most recently
from
483747e to
7b01cca
Compare
Contributor
AnthonyRonning
left a comment
AnthonyRonning
left a comment
There was a problem hiding this comment.
Still reviewing and need to test but here's a few initial things
Contributor
|
Do you think this is something we can use? I really like this idea: ElementsProject/lightning#5361 |
Collaborator
Author
Made an issue, would be cool to do eventually, probably easier to ignore for now |
benthecarman
force-pushed
the
scb
branch
2 times, most recently
from
7223298 to
c60c94f
Compare
AnthonyRonning
approved these changes
Jun 27, 2023
Contributor
AnthonyRonning
left a comment
AnthonyRonning
left a comment
There was a problem hiding this comment.
Code looks solid. Will come down to more testing I think but I think we can go ahead and merge and get this in the settings and emergency page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #237
Initial implementation of static channel backups, stores the channel monitors and when you attempt to recover it'll send a dummy channel re-establish event to tell the counter party to force close the channel.
Things still todo in follow ups:
encrypt backups