Numerous build issues

[adamjstewart]

Hi, I'm trying to create a package for OpenDX in the Spack package manager. On macOS, I encounter dozens of build issues. On Linux, I get a bit further, but the build eventually crashes with:

sh ../../../libtool --tag=CC --mode=compile /data/keeling/a/adamjs5/spack/lib/spack/env/gcc/gcc -DHAVE_CONFIG_H -I. -I. -I../../../include -I../../../include  -Dlinux    -g -O2 -D_GNU_SOURCE -c -o memory.lo memory.c
 /data/keeling/a/adamjs5/spack/lib/spack/env/gcc/gcc -DHAVE_CONFIG_H -I. -I. -I../../../include -I../../../include -Dlinux -g -O2 -D_GNU_SOURCE -c memory.c -o memory.o
memory.c:68:23: fatal error: linux/sys.h: No such file or directory
 #include <linux/sys.h>
                       ^
compilation terminated.
make[4]: *** [memory.lo] Error 1
make[4]: *** Waiting for unfinished jobs....
make[4]: Leaving directory `/tmp/adamjs5/spack-stage/spack-stage-opendx-master-vhflyigo5hjmi427b4ulxirw6azbmjxc/spack-src/src/exec/libdx'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/tmp/adamjs5/spack-stage/spack-stage-opendx-master-vhflyigo5hjmi427b4ulxirw6azbmjxc/spack-src/src/exec/libdx'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/adamjs5/spack-stage/spack-stage-opendx-master-vhflyigo5hjmi427b4ulxirw6azbmjxc/spack-src/src/exec'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/adamjs5/spack-stage/spack-stage-opendx-master-vhflyigo5hjmi427b4ulxirw6azbmjxc/spack-src/src'
make: *** [all-recursive] Error 1

I think linux/sys.h is a private header that isn't included in the OS when Linux gets built. I can try removing the #include, but I have no idea what the repercussions of this are.

[adamjstewart]

I think the issue can be resolved with the following patch:

diff --git a/src/exec/libdx/memory.c b/src/exec/libdx/memory.c
index aceaf53..6ea8329 100644
--- a/src/exec/libdx/memory.c
+++ b/src/exec/libdx/memory.c
@@ -65,7 +65,7 @@
 
 #if linux
 #include <linux/kernel.h>
-#include <linux/sys.h>
+#include <linux/sysctl.h>
 #include <sys/sysinfo.h>
 #endif
 

But then I encounter new build issues:

/data/keeling/a/adamjs5/spack/lib/spack/env/gcc/g++ -DHAVE_CONFIG_H -I. -I. -I../../../include -I./../base -I../../../include -I./../dxui -Dlinux    -g -O2 -c -o CDBAllocatorDictionary.o CDBAllocatorDictionary.C
In file included from AutoAxesDialog.C:39:0:
ticks_in.bm:7:74: error: narrowing conversion of '130' from 'int' to 'char' inside { } [-Wnarrowing]
    0x92, 0x24, 0x01, 0xfe, 0xff, 0x03, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
                                                                          ^
ticks_in.bm:7:74: error: narrowing conversion of '130' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in.bm:7:74: error: narrowing conversion of '146' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in.bm:7:74: error: narrowing conversion of '146' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in.bm:7:74: error: narrowing conversion of '146' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in.bm:7:74: error: narrowing conversion of '146' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in.bm:7:74: error: narrowing conversion of '254' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in.bm:7:74: error: narrowing conversion of '255' from 'int' to 'char' inside { } [-Wnarrowing]
In file included from AutoAxesDialog.C:40:0:
ticks_out.bm:7:74: error: narrowing conversion of '254' from 'int' to 'char' inside { } [-Wnarrowing]
    0x24, 0x49, 0x02, 0x24, 0x49, 0x02, 0x20, 0x08, 0x02, 0x20, 0x08, 0x02};
                                                                          ^
ticks_out.bm:7:74: error: narrowing conversion of '255' from 'int' to 'char' inside { } [-Wnarrowing]
In file included from AutoAxesDialog.C:41:0:
ticks_in_ins.bm:7:74: error: narrowing conversion of '130' from 'int' to 'char' inside { } [-Wnarrowing]
    0x82, 0x20, 0x00, 0x54, 0x55, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
                                                                          ^
ticks_in_ins.bm:7:74: error: narrowing conversion of '130' from 'int' to 'char' inside { } [-Wnarrowing]
ticks_in_ins.bm:7:74: error: narrowing conversion of '130' from 'int' to 'char' inside { } [-Wnarrowing]
In file included from AutoAxesDialog.C:42:0:
ticks_out_ins.bm:7:74: error: narrowing conversion of '170' from 'int' to 'char' inside { } [-Wnarrowing]
    0x20, 0x08, 0x02, 0x04, 0x41, 0x00, 0x20, 0x08, 0x02, 0x00, 0x00, 0x00};
                                                                          ^
ticks_out_ins.bm:7:74: error: narrowing conversion of '170' from 'int' to 'char' inside { } [-Wnarrowing]
/data/keeling/a/adamjs5/spack/lib/spack/env/gcc/g++ -DHAVE_CONFIG_H -I. -I. -I../../../include -I./../base -I../../../include -I./../dxui -Dlinux    -g -O2 -c -o ColormapAddCtlDialog.o ColormapAddCtlDialog.C
/data/keeling/a/adamjs5/spack/lib/spack/env/gcc/g++ -DHAVE_CONFIG_H -I. -I. -I../../../include -I./../base -I../../../include -I./../dxui -Dlinux    -g -O2 -c -o ColormapEditor.o ColormapEditor.C

[roguephysicist]

@adamjstewart, your patch does indeed fix the first issue. Compiling with GCC 4.8.5 seems to work well. Perhaps the solution is simply limiting the compiler version within Spack?

[adamjstewart]

I no longer have access to Linux to test this, and it never worked on macOS, but feel free to use my patch to create a Spack package.