MCR-3445 increase request buffer size in solrj #2538
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsteph-de
force-pushed
the
issues/MCR-3445_increase_request_buffer_size_in_solrj
branch
from
7d94ff6 to
8d9928f
Compare
toKrause
requested changes
Jun 3, 2025
|
|
||
| Method mSetRequestBufferSize = jettyHttpClient.getClass() | ||
| .getDeclaredMethod("setRequestBufferSize", int.class); | ||
| mSetRequestBufferSize.invoke(jettyHttpClient, 511 * 1024); |
Contributor
There was a problem hiding this comment.
Why this specific hard-coded value? Could be a configuration property for applications that need an even larger buffer size.
Member
Author
There was a problem hiding this comment.
Good idea. we can even use the exististence of the property to decide if the modifications are necessary.
(see commit)
rsteph-de
force-pushed
the
issues/MCR-3445_increase_request_buffer_size_in_solrj
branch
from
8d9928f to
cf6064a
Compare
by Java reflection
rsteph-de
force-pushed
the
issues/MCR-3445_increase_request_buffer_size_in_solrj
branch
from
cf6064a to
704fbe6
Compare
toKrause
approved these changes
Jul 11, 2025
Member
Author
|
I am setting this back to draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to jira.