Skip to content

feat(ui): replace fontawesome with hosted material symbols#2

Merged
thatplatypus merged 2 commits intomainfrom
feat-replace-font-awesome
Jul 5, 2025
Merged

feat(ui): replace fontawesome with hosted material symbols#2
thatplatypus merged 2 commits intomainfrom
feat-replace-font-awesome

Conversation

@thatplatypus
Copy link
Copy Markdown
Contributor

Not perfect yet but this makes significant progress as is

@thatplatypus thatplatypus requested a review from Copilot June 22, 2025 02:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces usage of FontAwesome icons with hosted Material Symbols across the UI.

  • Swaps out the external FontAwesome stylesheet for the Material Symbols CSS in the main HTML.
  • Refactors IrisIcons helpers and related icon type mappings to emit Material Symbols names.
  • Disables legacy active-state icon replacement in IrisNavLink and removes an unused test project reference.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Iris.Desktop/wwwroot/index.html Replaced FontAwesome CSS link with hosted Material Symbols CSS
Iris.Desktop/azure-pipeline.yml Deleted Azure pipeline configuration
Iris.Components/Theme/IrisIcons.cs Updated icon helper methods to use Material Symbols naming
Iris.Components/Theme/IrisIcons.Types.cs Updated type-specific icons to Material Symbols
Iris.Components/Navigation/IrisNavLink.razor Commented out active-state icon logic pending Material Symbols fix
Iris.Components.Test/Iris.Components.Test.csproj Removed Iris.Cloud.Client project reference from the test project
Comments suppressed due to low confidence (2)

Iris.Components.Test/Iris.Components.Test.csproj:27

  • Removing the Iris.Cloud.Client project reference may lead to test failures if any tests rely on those types; confirm tests no longer need this reference or update them accordingly.
  <ItemGroup>

Comment on lines +43 to +44
//ToDo fix for material symbols
return Icon; //isActive ? Icon.Replace("rounded", "filled") : Icon;
Copy link

Copilot AI Jun 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out logic prevents the active-state icon from being applied. Either implement the Material Symbols replacement logic or remove the TODO and cleanup this method to avoid confusion.

Suggested change
//ToDo fix for material symbols
return Icon; //isActive ? Icon.Replace("rounded", "filled") : Icon;
return isActive ? Icon.Replace("rounded", "filled") : Icon;

Copilot uses AI. Check for mistakes.
@thatplatypus thatplatypus merged commit 5e0bf8f into main Jul 5, 2025
thatplatypus added a commit that referenced this pull request Mar 1, 2026
feat(ui): replace fontawesome with hosted material symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants