Removed superfluous override of WMS_VERSION #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter WMS_VERSION is already read from configuration and set in the params varable. To overwrite it here will only make it impossible to change by configuration.
| setFallbacks(params); | ||
|
|
||
| // Setup WMS URL builder. | ||
| params.setValue(AVKey.WMS_VERSION, caps.getVersion()); |
Author
There was a problem hiding this comment.
This is already done at line 130, IF the params does not contain a value already. This line just overwrites any WMS_VERSION that might be set in configuration.
pdavidc
pushed a commit
that referenced
this pull request
Dec 12, 2016
Applies pull request #13 to the develop branch.
|
We've switched to a Git Flow branching model since this pull request was submitted. In the interest of getting this trivial change in to v2.1.0, we've manually applied this pull request to the develop branch. See commit 52afdee. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter WMS_VERSION is already read from configuration and set in
the params varable. To overwrite it here will only make it impossible to
change by configuration.