feat: Add clamping variables to MOM6, set vertical localization coord, vert interp#1033
Merged
hkershaw-brown merged 4 commits intomainfrom Mar 6, 2026
Merged
feat: Add clamping variables to MOM6, set vertical localization coord, vert interp#1033hkershaw-brown merged 4 commits intomainfrom
hkershaw-brown merged 4 commits intomainfrom
Conversation
hkershaw-brown
force-pushed
the
mom6-clamp-variables
branch
from
2919985 to
d1c0f4f
Compare
Member
Author
|
@hkershaw-brown add set_vertical see #1039 |
hkershaw-brown
force-pushed
the
mom6-clamp-variables
branch
from
d1c0f4f to
76de4fc
Compare
Member
Author
|
@hkershaw-brown also #1048 #1047 |
Member
Author
|
putting MOM6 set_vertical_localization_coordinate in MOM6 pull request. doc & template model "fix" for #1039 going in separate pull request. Maybe code fix also. 🙃 |
hkershaw-brown
changed the title
hkershaw-brown
force-pushed
the
mom6-clamp-variables
branch
from
75df4b6 to
5621cdf
Compare
hkershaw-brown
changed the title
mjs2369
approved these changes
Mar 3, 2026
Contributor
mjs2369
left a comment
mjs2369
left a comment
There was a problem hiding this comment.
Hi @hkershaw-brown these code changes all look good, sufficiently fixing issues #1047 #1039 (MOM6 only) #1028
hkershaw-brown
force-pushed
the
mom6-clamp-variables
branch
from
d30a67d to
92bca08
Compare
only VERTISHEIGHT allowed, error if convert_vertical_state is called with other vertical coordinate see #1039 set_vertical_localization_coord is required for models doing vertical localization
hkershaw-brown
force-pushed
the
mom6-clamp-variables
branch
from
92bca08 to
7a31f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request has MOM6 fixes:
Adds clamping variables to MOM6 model_mod.
Uses parse_variables_clamp
Requires breaking input.nml change if people are already using DART-MOM6. - release notes need to mention this.
CESM3.0 is not released yet, but there are people using MOM6-DART.
sets vertical localization coord
Fixes vertical interpolation for thickness and psuedodepth methods
These are in separate commits, I can move to separate pull requests as needed.
Fixes issue
fixes #1028
see #1039 set_vertical_localization_coord is required for models doing vertical localization
fixes #1048
fixes #1047
Types of changes
Documentation changes needed?
Tests
Please describe any tests you ran to verify your changes.
Running filter with clamping on.
Checklist for merging
Checklist for release
Testing Datasets