Merged
Conversation
We could write logs into the Docker, but I can't figure out how to send that to stderr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading NodeNorm data into Redis databases, we have been using redis-rdb-tools, which is five years old and only supports RDB files until Redis v6. This PR adds librdb, which is up to date and maintained by Redis itself, and so should support more recent versions of Redis. The tool should support the data upload system we like in place of redis-rdb-tools.
Remember that we only need the copy system because we specifically want to support the case where we deploy to AWS without restoring an RDB bucket from an S3 bucket. Once we've moved over to NodeNorm ES, we won't need to do that any longer, and can get rid of this system entirely and restore RDB in more straightforward ways.