Skip to content

Reduce dependencies on ncdf4 and yaml#87

Merged
amoeba merged 4 commits intomasterfrom
reduce-dependencies
May 11, 2018
Merged

Reduce dependencies on ncdf4 and yaml#87
amoeba merged 4 commits intomasterfrom
reduce-dependencies

Conversation

@amoeba
Copy link
Contributor

@amoeba amoeba commented May 10, 2018

@isteves helpfully noted that the Travis CI builds started failing a while ago in #86. The failures indicate issues with Ubuntu PPAs and nothing to do with our tools. Though this happened around the time R 3.5.0 was released, which is a backwards incompatible R release indue to the introduction of ALTREP. This is:

  1. My attempt to fix that so all the Travis builds pass
  2. Reduce the deps arcticdatautils requires to install. ncdf4 and yaml are not packages that need to be installed to get started using it so they should be in Suggests

@isteves helpfully noted that the Travis CI builds started failing a while ago in #86. The failures indicate issues with Ubuntu PPAs and nothing to do with our tools. Though this happened around the time R 3.5.0 was released, which is a backwards incompatible R release indue to the introduction of ALTREP. This is:

1. My attempt to fix that so all the Travis builds pass
2. Reduce the deps arcticdatautils requires to install. ncdf4 and yaml are not packages that _need_ to be installed to get started using it so they should be in Suggests
@amoeba amoeba self-assigned this May 10, 2018
@csjx csjx added the review label May 10, 2018
@amoeba amoeba merged commit 82bc8bc into master May 11, 2018
@amoeba amoeba deleted the reduce-dependencies branch May 11, 2018 17:18
laijasmine pushed a commit that referenced this pull request Oct 2, 2020
Reduce dependencies on ncdf4 and yaml
Also fix travis build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants