Login/Onboarding flow update#125
Merged
elliotBraem merged 12 commits intoNEARBuilders:developfrom Feb 6, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Profile Page * Style updates * Style updates to profile page * Fix projects page * Fix projects page * Clear compose draft when post * Resolve comments * Fix more hrefs * Change more href * Remove layout loading text * Try to fix all VM requires * Fix flashes on home page * Replace all VM.require fallbacks to correct object * Run prettier * Use correct fallback for DaoSDK * Remove un needed tag from compose * Fix compose rerender on commit * Remove unneeded css --------- Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com>
Collaborator
Author
|
Just for clarity, I have added these three screens for onboarding and used private storage to know if the user is first time login or not |
Collaborator
Author
|
Question: currently I show “Following” and disabled button if the user is already following an account, should we allow unfollow which is the normal behaviour.? |
Contributor
|
This looks great! Some feedback:
|
Collaborator
Author
|
hey @elliotBraem, added all the feedback points. |
elliotBraem
added a commit
that referenced
this pull request
Feb 7, 2024
* Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Profile Page * Style updates * Style updates to profile page * Fix projects page * Fix projects page * Clear compose draft when post * Resolve comments * Fix more hrefs * Change more href * Remove layout loading text * Try to fix all VM requires * Fix flashes on home page * Replace all VM.require fallbacks to correct object * Run prettier * Use correct fallback for DaoSDK * Remove un needed tag from compose * Fix compose rerender on commit * Remove unneeded css * Remove pinned comment as it is duplicate of bio * Fix bookmark button hover * Login/Onboarding flow update (#125) * updated navbar, deleted join page * Clean up (#121) * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Profile Page * Style updates * Style updates to profile page * Fix projects page * Fix projects page * Clear compose draft when post * Resolve comments * Fix more hrefs * Change more href * Remove layout loading text * Try to fix all VM requires * Fix flashes on home page * Replace all VM.require fallbacks to correct object * Run prettier * Use correct fallback for DaoSDK * Remove un needed tag from compose * Fix compose rerender on commit * Remove unneeded css --------- Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com> * added onboarding flow screens * finish setup * rename files * minor bug fix * add following logic * fix the visibility issue * suggestive changes --------- Co-authored-by: Elliot Braem <16282460+elliotBraem@users.noreply.github.com> Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com> --------- Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com> Co-authored-by: Megha-Dev-19 <100185149+Megha-Dev-19@users.noreply.github.com>
itexpert120
added a commit
that referenced
this pull request
Feb 9, 2024
* updated navbar, deleted join page * Clean up (#121) * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Profile Page * Style updates * Style updates to profile page * Fix projects page * Fix projects page * Clear compose draft when post * Resolve comments * Fix more hrefs * Change more href * Remove layout loading text * Try to fix all VM requires * Fix flashes on home page * Replace all VM.require fallbacks to correct object * Run prettier * Use correct fallback for DaoSDK * Remove un needed tag from compose * Fix compose rerender on commit * Remove unneeded css --------- Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com> * added onboarding flow screens * finish setup * rename files * minor bug fix * add following logic * fix the visibility issue * suggestive changes --------- Co-authored-by: Elliot Braem <16282460+elliotBraem@users.noreply.github.com> Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com>
elliotBraem
added a commit
that referenced
this pull request
Feb 11, 2024
* fix href * Profile Page * Try to fix all VM requires * Replace all VM.require fallbacks to correct object * Use correct fallback for DaoSDK * Remove pinned comment as it is duplicate of bio * Events monthly view and create modal * Add filter modal * wip: data fetch and create * Comments * fix: events query * Fetch events and list events * Filters * Change filter button names * Border radius * Revert "Border radius" * Login/Onboarding flow update (#125) * updated navbar, deleted join page * Clean up (#121) * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Fix post colors to match figma * Add stroke to compose for more coherent UI * Profile in progress, some fixes * rename * fix href * Profile Page * Style updates * Style updates to profile page * Fix projects page * Fix projects page * Clear compose draft when post * Resolve comments * Fix more hrefs * Change more href * Remove layout loading text * Try to fix all VM requires * Fix flashes on home page * Replace all VM.require fallbacks to correct object * Run prettier * Use correct fallback for DaoSDK * Remove un needed tag from compose * Fix compose rerender on commit * Remove unneeded css --------- Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com> * added onboarding flow screens * finish setup * rename files * minor bug fix * add following logic * fix the visibility issue * suggestive changes --------- Co-authored-by: Elliot Braem <16282460+elliotBraem@users.noreply.github.com> Co-authored-by: Zeeshan Ahmad <itexpert120@outlook.com> * rename fetchEvents to fetchThings * Fix clear filter not clearing date * Rename image upload widget * Convert hashtags into component * Replace events with things in everything sdk * Add location, organizer, and link to list view * Replace test with every * Fix Bullet component in Join section --------- Co-authored-by: Elliot Braem <16282460+elliotBraem@users.noreply.github.com> Co-authored-by: Megha-Dev-19 <100185149+Megha-Dev-19@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #117
Resolves #84
Resolves #85