Skip to content

add Mintbase wallet#275

Closed
saadiqbal-dev wants to merge 10 commits intomainfrom
mintbase-wallet
Closed

add Mintbase wallet#275
saadiqbal-dev wants to merge 10 commits intomainfrom
mintbase-wallet

Conversation

@saadiqbal-dev
Copy link
Copy Markdown
Collaborator

@saadiqbal-dev saadiqbal-dev commented May 3, 2024

resolves #266

2024-05-03.09-19-43.mp4

@vercel
Copy link
Copy Markdown

vercel Bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gateway ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 2:21pm

@elliotBraem
Copy link
Copy Markdown
Contributor

elliotBraem commented May 3, 2024

I think you need to pull master and then can you update near-wallet selector to 8.9.7 so we can use the new Here wallet?

https://github.com/near/wallet-selector/releases/tag/v8.9.7

Update ALL of the near-wallet-selector libraries (including modal and core) to use the same version, 8.9.7

Jikugodwill
Jikugodwill reviewed May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Jikugodwill Jikugodwill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could complete with #259 and pull changes before trying to merge this, perhaps this could be draft?

@saadiqbal-dev
Copy link
Copy Markdown
Collaborator Author

saadiqbal-dev commented May 3, 2024

I think you need to pull master and then can you update near-wallet selector to 8.9.7 so we can use the new Here wallet?

https://github.com/near/wallet-selector/releases/tag/v8.9.7

Update ALL of the near-wallet-selector libraries (including modal and core) to use the same version, 8.9.7

Zeeshan has done that in this PR

#276

itexpert120
itexpert120 reviewed May 3, 2024
View reviewed changes
Comment thread apps/builddao/widget/components/modals/CreateEvent.jsx Outdated
title={"Create Event"}
onOpenChange={toggleModal}
toggle={toggle}
theme={bootstrapTheme}
Copy link
Copy Markdown
Collaborator

@itexpert120 itexpert120 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename bootstrapTheme with just theme

Comment thread apps/builddao/widget/components/modals/FilterEvents.jsx Outdated
title={"Filter Events"}
onOpenChange={toggleModal}
toggle={toggle}
theme={bootstrapTheme}
Copy link
Copy Markdown
Collaborator

@itexpert120 itexpert120 May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too

@Megha-Dev-19 Megha-Dev-19 mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itexpert120 itexpert120 itexpert120 left review comments

@Jikugodwill Jikugodwill Jikugodwill left review comments

@Megha-Dev-19 Megha-Dev-19 Awaiting requested review from Megha-Dev-19 Megha-Dev-19 is a code owner

@elliotBraem elliotBraem Awaiting requested review from elliotBraem elliotBraem is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Mintbase Wallet to Wallet selector

4 participants

@saadiqbal-dev @elliotBraem @itexpert120 @Jikugodwill