Creating Modal component + Adding X Icon to icons folder#62
Merged
elliotBraem merged 4 commits intoNEARBuilders:mainfrom Jan 15, 2024
Merged
Creating Modal component + Adding X Icon to icons folder#62elliotBraem merged 4 commits intoNEARBuilders:mainfrom
elliotBraem merged 4 commits intoNEARBuilders:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elliotBraem
requested changes
Jan 15, 2024
| @@ -0,0 +1,18 @@ | |||
| import React from "react" | |||
Contributor
There was a problem hiding this comment.
Should this be in this PR?
| @@ -0,0 +1,76 @@ | |||
| const { theme } = VM.require("rambo-dev.near/widget/ThemeProvider"); | |||
Contributor
There was a problem hiding this comment.
Can we not use the ThemeProvider please? We can explore this in the future.
Theming does not need to happen on a per-component basis. We will just define the Theme in the root.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.