Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
elliotBraem
reviewed
Jan 22, 2024
| } | ||
| `; | ||
|
|
||
| function ButtonLink({ id, children, variant, type, href, className, style }) { |
Contributor
There was a problem hiding this comment.
Renaming to ButtonLink is going to break current implementations -- it only still works because the Button code has been pushed on chain and can always be referenced, but we lose the parity with our code base.
Can this be renamed to Button? Then add a condition that checks for href and renders accordingly
Collaborator
Author
There was a problem hiding this comment.
I tried that, the implementation does not look that pretty and didn't worked for some reason. But if you want, I'll do it
elliotBraem
approved these changes
Jan 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.