This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Minor refactors and fixing S3 --buckets flag#138
Merged
Conversation
- A package can still be created if required, for now this improves the readability
Member
Author
|
@pdorschner I added a flag to toggle whether no buckets should be OK or UNKNOWN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add proper error handling to
--bucketsflag.Fixes #136
However, should be noted that this now fails with
UNKOWNif there are no buckets. A flag was added to toggle this behaviour.This branch also has some minor refactors: