Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Refactor for Unit Tests and simplification #6

Merged
martialblog merged 9 commits into from
May 8, 2023
Merged

Refactor for Unit Tests and simplification #6

martialblog merged 9 commits into from
May 8, 2023

Conversation

@martialblog
Copy link
Member

@martialblog martialblog commented May 5, 2023 •
edited
Loading

Future maintainability refactor

  • Adds Unit Tests
  • GH Actions
  • Refactors command-line-args parsing testing
  • Improve some output messages
  • Refactor perfdata printing to have less function calls
  • Indent sub-check ouput for readability
  • Improve sub-check status output (now shows only OK or CRITICAL)
  • Remove newlines and quotes from perfdata
  • Optimize -x option to be used multiple times

Fixes #3

@martialblog martialblog self-assigned this May 5, 2023
@martialblog martialblog force-pushed the feature/device-info branch from 9e78472 to 21a4ee8 Compare May 5, 2023 18:51
@martialblog martialblog marked this pull request as ready for review May 5, 2023 18:51
@martialblog
Copy link
Member Author

martialblog commented May 5, 2023 

python -m coverage report -m --include check_hp_ilo.py
Name              Stmts   Miss  Cover   Missing
-----------------------------------------------
check_hp_ilo.py      61      0   100%

🎤 💧

@martialblog martialblog force-pushed the feature/device-info branch from a5d2e56 to ae6af8a Compare May 5, 2023 19:15
@martialblog martialblog force-pushed the feature/device-info branch from ae6af8a to 84ff099 Compare May 5, 2023 19:17
@martialblog martialblog requested a review from RincewindsHat May 5, 2023 19:24
Markus Opolka added 3 commits May 6, 2023 16:29
Optimize sub check outout
9db3b51 
 - before this change there was the return text of the ILO
   instead of OK/CRITICAL in the output
Update README
78819db
Optimize -x option to be used multiple times
cc7285a
@martialblog martialblog force-pushed the feature/device-info branch from ea0ba2b to cc7285a Compare May 6, 2023 14:30
@martialblog martialblog added this to the v0.1.0 milestone May 8, 2023
@martialblog martialblog merged commit 4101652 into main May 8, 2023
@martialblog martialblog deleted the feature/device-info branch May 8, 2023 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RincewindsHat RincewindsHat Awaiting requested review from RincewindsHat

Assignees

@martialblog martialblog

Labels

None yet

Projects

None yet

Milestone

v0.1.0

Development

Successfully merging this pull request may close these issues.

get device info

2 participants

@martialblog