Skip to content

add new parameter "URL" to access Prometheus behind reverse proxy#59

Merged
martialblog merged 3 commits into
NETWAYS:mainfrom
gunzl1ng3r:main
Nov 28, 2024
Merged

add new parameter "URL" to access Prometheus behind reverse proxy#59
martialblog merged 3 commits into
NETWAYS:mainfrom
gunzl1ng3r:main

Conversation

@gunzl1ng3r
Copy link
Copy Markdown
Contributor

Context: We have multiple Prometheus instances accessible behind a reverse proxy.

This add a new parameter -U/--url that allows to append an URL/a path behind "hostname:port".

@RincewindsHat
Copy link
Copy Markdown
Member

Hi @gunzl1ng3r,
thanks for the contribution. Could please take a look at the failing test cases?

@martialblog martialblog self-assigned this Nov 8, 2024
@martialblog
Copy link
Copy Markdown
Member

Thanks.

I think this change makes sense. I'll give it a test but so far looks good.

Maybe we should add a simple example to the README.

@martialblog martialblog added this to the v0.3.0 milestone Nov 28, 2024
@martialblog
Copy link
Copy Markdown
Member

Looks good.

Thanks for the PR!

@martialblog martialblog merged commit abef324 into NETWAYS:main Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants