Rework logic when there are no alerts defined#66
Merged
Conversation
1 task
martialblog
commented
Dec 16, 2024
martialblog
force-pushed
the
no-alerts-logic
branch
from
677829d to
b37570f
Compare
|
Sorry, I wrote my results here |
Member
RincewindsHat
left a comment
RincewindsHat
left a comment
There was a problem hiding this comment.
Small not regarding a variable name.
Apart from that, good to go
Changes default to OK, instead of UNKNOWN. Added a check to see if the API response contains alert rules. If not, we exit early. To add extra flexibility this also adds a --no-alerts-state flag that can be used to set the desired exit state when no alerts are found.
martialblog
force-pushed
the
no-alerts-logic
branch
from
b37570f to
c4706c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reworked to logic when no alerts are returned from the API.
Changes default to OK, instead of UNKNOWN.
Added a check to see if the API response contains alert rules. If not, we exit early.
To add extra flexibility this also adds a
--no-alerts-state flagthat can be used to set the desired exit state when no alerts are found.See #65