Skip to content

Remove Strings as perfdata values #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RincewindsHat merged 3 commits into from
Jun 20, 2024
Merged

Remove Strings as perfdata values #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46b51f8
Remove Strings as perfdata values
Jun 20, 2024
3bdec50
Use float64 specifically in test case to cover that base
Jun 20, 2024
e1ee1f8
Remove string testcase and make the other easier to pick apart
Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions perfdata/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ func formatNumeric(value interface{}) (string, error) {
return check.FormatFloat(float64(v)), nil
case int, int8, int16, int32, int64, uint, uint8, uint16, uint32, uint64:
return fmt.Sprintf("%d", v), nil
case fmt.Stringer, string:
return fmt.Sprint(v), nil
default:
panic(fmt.Sprintf("unsupported type for perfdata: %T", value))
}
Expand Down
9 changes: 3 additions & 6 deletions perfdata/type_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,11 @@ func TestFormatNumeric(t *testing.T) {
},
{
Result: "1234.567",
InputValue: 1234.567,
InputValue: float64(1234.567),
},
{
Result: "1234.567",
InputValue: float32(1234.567),
},
{Result: "1234.567",
InputValue: "1234.567",
Result: "3456.789",
InputValue: float32(3456.789),
},
{
Result: "1234567890.988",
Expand Down