HumanReadable: respect zero value input#46
Merged
Conversation
tbauriedel
approved these changes
Mar 14, 2022
tbauriedel
left a comment
tbauriedel
left a comment
There was a problem hiding this comment.
LGTM.
@RincewindsHat Second review and merge if ok please
| // | ||
| func humanReadable(b uint64, units []string, base float64) (float64, string) { | ||
| if b == 0 { | ||
| return 0, "MB" |
Member
There was a problem hiding this comment.
Sorry for nitpicking, but why not B instead of MB? Small efficiency improvement at not cost and no doubt about rounding errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a zero value input is parsed by
HumanReadable, it should return always "0MB" and not apanic