Refactor perfdata strings#88
Merged
Merged
Conversation
- The perfdata code does a lot of string operations, we might want to optimize it in the future - Example usage go test -run=. -bench=BenchmarkPerfdataString -count=10 ./... | tee 1.benchmark
- Moved util.go into type.go since 'util' is too generic a name - Made formatting function private, since they should not be used outside the module - Refactored tests to be table driven - Less restrictive character set for labels
ca220b3 to
4e4b05c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
Also:
go test -run=. -bench=. -count=12 ./perfdata/... | tee my.benchmarkThe benchmark for the refactor.
Current master:
Refactor: