Remove http sub package to focus the purpose of this library#90
Merged
Conversation
Member
|
@RincewindsHat I know this i used in some downstream code. I do think the code is useful, it just might need a different place. |
Member
|
I will have a look at our code base to see where we use this. I think it is only a few tests, if so I will just copy this code where it's needed. |
Member
Author
|
or put in another repo? Vendoring it to five places might more pain in the longterm. |
Member
|
Yeah that could also be an option. I do think it is not even five places, let me check and then we will see. |
Member
|
As far as I can see, it is only used in: check_cloud_azure, check_cloud_gcp, check_cloud_aws I think, a we can take a little duplication over the wrong abstraction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.