Feature/set num threads #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @warn "You can't modify the C pointer to the NFCT plan." | ||
| elseif v == :num_threads | ||
| @warn "You can't currently modify the number of threads." | ||
| @warn "You can't currently modify the number of threads of the NFCT plan. Use NFCT.set_num_threads(nthreads) instead." |
Member
There was a problem hiding this comment.
Why don't you put the code from line 343 here? I guess it might be easier to modify the calue directly
Contributor
Author
There was a problem hiding this comment.
Originally, I wanted to add the set_num_threads to the plan exactly there. However, I decided against it, since this is not a plan-specific setting but a global setting for the whole runtime.
* So we use gcc9 and julia out of the box * Install only necessary msys packages
There seems to be a dependency problem with clang7 and llvm10 in focal. This also moves tests with nonstandard window functions to the end
felixbartel
approved these changes
Aug 28, 2020
Member
felixbartel
left a comment
felixbartel
left a comment
There was a problem hiding this comment.
Tested it with Julia and everything worked! Handling global variables is still a mess.
Use precision independent nfft functions in fastsum
michaelquellmalz
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added possibility to set number of OpenMP threads for Julia and Matlab interface. In particular, Matlab seems to ignore the environment variable
OMP_NUM_THREADSsometimes.