Skip to content

Conversation

@f-hafner
Copy link
Contributor

@f-hafner f-hafner commented Dec 6, 2023

I propose a fix to #290:

  • recommend Github actions as default for distributing packages through pypi; update links to documentation
  • suggest workflow with testpypi and manual uploads with 2FA for debugging, based on the discussion in said issue

Notes

  • I have not tried out the "new" manual way with 2FA
  • I removed the link to the twine tutorial as it's outdated

Questions

  • signing distribution packages is not described, but it's here -- should I add something about it?
  • should the release workflow in the python template (the generated README.dev.md) be synced with the changes made here?

@f-hafner f-hafner requested a review from egpbos December 6, 2023 08:26
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! ✨ I would suggest reducing the amount of text a bit because that will make it easier to maintain: maybe remove the links to examples and the extensive explanation of how to use test pypi (link to an external resource describing this workflow instead)?

Updating the python-template so it follows what is described in the guide would be nice.

f-hafner and others added 2 commits January 18, 2024 13:17
Co-authored-by: Bouwe Andela <bouweandela@gmail.com>
@f-hafner
Copy link
Contributor Author

f-hafner commented Jan 18, 2024

I shortened as suggested, what do you think?

To update the template, I will make an issue.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants