Skip to content

Conversation

@PabRod
Copy link
Member

@PabRod PabRod commented Dec 3, 2024

Changes in this PR

The R language kept evolving since we wrote this. It needs some updates

Checklist

SIGNIFICANT changes / additions, e.g. new chapters

  • I checked whether the contribution fits in The Turing Way before considering contributing to this Guide.
  • I discussed my contribution in an issue and took into account feedback.

ALL contributions

  • I previewed my changes locally using e.g. python3 -m http.server 4000 and confirmed they work correctly.
  • I checked for broken links, e.g. using the link checker GitHub Action workflow, or locally by using docker run --init -it -v `pwd`:/docs lycheeverse/lychee /docs --config=docs/lychee.toml, at least for the files I changed.
  • My name was added to the CITATION.cff file.

@PabRod PabRod linked an issue Dec 3, 2024 that may be closed by this pull request
@PabRod PabRod changed the title Add shortcut on paragraph about assignment operator Update R chapter Dec 3, 2024
@maltelueken
Copy link
Member

Perhaps, we should also mention R Shiny?

@PabRod
Copy link
Member Author

PabRod commented Dec 3, 2024

The broken links check throws 14 errors, but none of them in the file I edited.

@PabRod PabRod marked this pull request as ready for review December 3, 2024 13:05
@PabRod
Copy link
Member Author

PabRod commented Dec 3, 2024

Ready to review and merge!

@PabRod PabRod requested a review from egpbos December 3, 2024 13:05
Copy link
Member

@maltelueken maltelueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a correction about the pipe operators (my bad, |> was introduced in R 4.1) and added a link to Rcpp for perfomant R code.

Otherwise, the PR looks really great. With the correction, it can be merged.

Copy link
Member

@c-martinez c-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a couple of minor things to consider changing, but otherwise its looking great!

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The R chapter as it currently is contains a lot of what Wikipedia would call "original research". It would be nice to replace this by a short introduction and references to established community standards.

PabRod and others added 6 commits December 4, 2024 13:05
Co-authored-by: Malte Lüken <malte_lueken@arcor.de>
Co-authored-by: Carlos Martinez <c.martinez@esciencecenter.nl>
Co-authored-by: Malte Lüken <malte_lueken@arcor.de>
Co-authored-by: Carlos Martinez <c.martinez@esciencecenter.nl>
@PabRod
Copy link
Member Author

PabRod commented Dec 5, 2024

Dear @egpbos. @maltelueken and I consider this ready to be merged!

@egpbos egpbos merged commit 39d8497 into main Dec 5, 2024
2 checks passed
@egpbos egpbos deleted the 336-r-chapter-maintenance branch December 5, 2024 14:23
@egpbos
Copy link
Collaborator

egpbos commented Dec 5, 2024

Awesome effort here, thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

R chapter maintenance

6 participants