-
Notifications
You must be signed in to change notification settings - Fork 30
Update R chapter #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update R chapter #367
Conversation
|
Perhaps, we should also mention R Shiny? |
|
The broken links check throws 14 errors, but none of them in the file I edited. |
|
Ready to review and merge! |
maltelueken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a correction about the pipe operators (my bad, |> was introduced in R 4.1) and added a link to Rcpp for perfomant R code.
Otherwise, the PR looks really great. With the correction, it can be merged.
c-martinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested a couple of minor things to consider changing, but otherwise its looking great!
bouweandela
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The R chapter as it currently is contains a lot of what Wikipedia would call "original research". It would be nice to replace this by a short introduction and references to established community standards.
Co-authored-by: Malte Lüken <malte_lueken@arcor.de>
Co-authored-by: Carlos Martinez <c.martinez@esciencecenter.nl>
Co-authored-by: Malte Lüken <malte_lueken@arcor.de>
Co-authored-by: Carlos Martinez <c.martinez@esciencecenter.nl>
About differences with Python. Now it's a link to a blog
|
Dear @egpbos. @maltelueken and I consider this ready to be merged! |
|
Awesome effort here, thanks all! |
Changes in this PR
The
Rlanguage kept evolving since we wrote this. It needs some updatesChecklist
SIGNIFICANT changes / additions, e.g. new chapters
ALL contributions
python3 -m http.server 4000and confirmed they work correctly.docker run --init -it -v `pwd`:/docs lycheeverse/lychee /docs --config=docs/lychee.toml, at least for the files I changed.CITATION.cfffile.