-
Notifications
You must be signed in to change notification settings - Fork 30
add version control to Best Practices chapter #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
best_practices/overview.md
Outdated
| This allows you to retrace your steps when debugging, keep your repository clean, easily collaborate with others asynchronously and more. | ||
| More info: [The Turing Way chapter on Version Control](https://book.the-turing-way.org/reproducible-research/vcs), [RSQkit chapter on Version Control](http://everse.software/RSQKit/version_control). | ||
|
|
||
| **@ NLeSC:** we always use version control and we preferably use GitHub as our online repository and collaboration platform (see the Project Management Protocol on the intranet). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding a hyperlink to "(see the Project Management Protocol on the intranet)" or omitting the statement. I tried googling the phrase and the reference was not clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Will do (I'll add it in a force pushed commit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, of course this breaks the link checker, because you need access...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it, added an exclude of the intranet domain to lychee. @vedran-kasalica ok to merge now?
Note also we started the discussion about this point in a separate issue: #399.
d1d3fb9 to
80b5981
Compare
3e6b2a0 to
c1bb8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating it. Looks good to me, feel free to merge it!
Fixes #376.