Skip to content

Conversation

@vedran-kasalica
Copy link
Collaborator

Changes in this PR

The PR solves #377

Checklist

SIGNIFICANT changes / additions, e.g. new chapters

  • I checked whether the contribution fits in The Turing Way before considering contributing to this Guide.
  • I discussed my contribution in an issue and took into account feedback.

ALL contributions

  • I previewed my changes locally using e.g. python3 -m http.server 4000 and confirmed they work correctly.
  • I checked for broken links, e.g. using the link checker GitHub Action workflow, or locally by using docker run --init -it -v `pwd`:/docs lycheeverse/lychee /docs --config=docs/lychee.toml, at least for the files I changed.
  • My name was added to the CITATION.cff file.

Copy link
Member

@c-martinez c-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :-)

@c-martinez
Copy link
Member

@egpbos , @fdiblen -- are there some EVERSE resources we could/should consider adding?

@jmaassen -- is it worth adding a link to EOSC quality TF?

@vedran-kasalica vedran-kasalica linked an issue Dec 4, 2024 that may be closed by this pull request
3 tasks
Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vedran-kasalica!

I suggested adding a link to RSQKit. The rest looks good for now.

@egpbos
Copy link
Collaborator

egpbos commented Dec 4, 2024

Alright, good to merge after rebasing on main.

@vedran-kasalica
Copy link
Collaborator Author

Alright, good to merge after rebasing on main.

I rebased it, so it can be merged as soon as it gets approved

Copy link
Member

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Please resolve the conflicts before merging.

@egpbos
Copy link
Collaborator

egpbos commented Dec 4, 2024

Shit, sorry @vedran-kasalica can you please force push your branch again? :D

@vedran-kasalica
Copy link
Collaborator Author

Shit, sorry @vedran-kasalica can you please force push your branch again? :D

No worries @egpbos I just did, can you merge the PR, I am not authorized :)

Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
@egpbos egpbos force-pushed the code-quality-#377 branch from 58d5d7f to ef44595 Compare December 4, 2024 14:53
@egpbos egpbos merged commit 4a6847f into main Dec 4, 2024
1 check passed
@egpbos egpbos deleted the code-quality-#377 branch December 4, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean-up and replace Code quality chapter

5 participants