-
Notifications
You must be signed in to change notification settings - Fork 30
Migrate Code quality to Best Practices chapter #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fc0c1ff to
fda6b3f
Compare
c-martinez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good :-)
|
@egpbos , @fdiblen -- are there some EVERSE resources we could/should consider adding? @jmaassen -- is it worth adding a link to EOSC quality TF? |
fdiblen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vedran-kasalica!
I suggested adding a link to RSQKit. The rest looks good for now.
|
Alright, good to merge after rebasing on main. |
d8c6c0e to
c45c566
Compare
I rebased it, so it can be merged as soon as it gets approved |
fdiblen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Please resolve the conflicts before merging.
c45c566 to
58d5d7f
Compare
58d5d7f to
d955adf
Compare
|
Shit, sorry @vedran-kasalica can you please force push your branch again? :D |
No worries @egpbos I just did, can you merge the PR, I am not authorized :) |
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
58d5d7f to
ef44595
Compare
Changes in this PR
The PR solves #377
Checklist
SIGNIFICANT changes / additions, e.g. new chapters
ALL contributions
python3 -m http.server 4000and confirmed they work correctly.docker run --init -it -v `pwd`:/docs lycheeverse/lychee /docs --config=docs/lychee.toml, at least for the files I changed.CITATION.cfffile.