ekobox unittests

[felixhekhorn]

• moved some code from benchmarks back to tests (those unrelated to lhapdf)

[codecov]

Codecov Report

Merging #109 (39338e8) into feature/composite-output (64f321b) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@                     Coverage Diff                      @@
##           feature/composite-output     #109      +/-   ##
============================================================
+ Coverage                     99.51%   99.60%   +0.09%     
============================================================
  Files                            39       51      +12     
  Lines                          2684     3055     +371     
============================================================
+ Hits                           2671     3043     +372     
+ Misses                           13       12       -1     

Flag	Coverage Δ
unittests	99.60% <100.00%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/eko/member.py	100.00% <ø> (ø)
src/ekobox/genpdf/flavors.py	100.00% <ø> (ø)
src/ekobox/__init__.py	100.00% <100.00%> (ø)
src/ekobox/evol_pdf.py	100.00% <100.00%> (ø)
src/ekobox/genpdf/__init__.py	100.00% <100.00%> (ø)
src/ekobox/genpdf/export.py	100.00% <100.00%> (ø)
src/ekobox/genpdf/load.py	100.00% <100.00%> (ø)
src/ekobox/info_file.py	100.00% <100.00%> (ø)
src/ekobox/operators_card.py	100.00% <100.00%> (ø)
src/ekobox/theory_card.py	100.00% <100.00%> (ø)
... and 13 more

[felixhekhorn]

@andreab1997 please take a look to ekobox and tell me what you think ... I did some renaming (e.g. gen_theory.gen_theory_card -> theory_card.generate) so you would most likely need to adjust the n3fit fit side ...

also I'm not really convinced of providing default runcards from banana: 1. are we really sure we want to do this? (instead of sticking to our default-less scheme - and in NNPDF we always have full runcards) and 2. if still, I don't think we should inherit from banana: our default theory there is FFNS3 which is good for debugging, but stupid in production ...

[andreab1997]

@andreab1997 please take a look to ekobox and tell me what you think ... I did some renaming (e.g. gen_theory.gen_theory_card -> theory_card.generate) so you would most likely need to adjust the n3fit fit side ...

Yes I'll take a look. Probably is only a matter of changing some names in evolven3fit.

also I'm not really convinced of providing default runcards from banana: 1. are we really sure we want to do this? (instead of sticking to our default-less scheme - and in NNPDF we always have full runcards) and 2. if still, I don't think we should inherit from banana: our default theory there is FFNS3 which is good for debugging, but stupid in production ...

I have not a strong opinion on that. I believe that for users having some defaults is good because most of them would only use a few of the runcards options. However maybe we can provide less and more "standard" defaults.

[andreab1997]

@andreab1997 please take a look to ekobox and tell me what you think ... I did some renaming (e.g. gen_theory.gen_theory_card -> theory_card.generate) so you would most likely need to adjust the n3fit fit side ...

also I'm not really convinced of providing default runcards from banana: 1. are we really sure we want to do this? (instead of sticking to our default-less scheme - and in NNPDF we always have full runcards) and 2. if still, I don't think we should inherit from banana: our default theory there is FFNS3 which is good for debugging, but stupid in production ...

Anyway, I really like the new names. The old ones were very confusing

[felixhekhorn]

Anyway, I really like the new names. The old ones were very confusing

you know whom to blame 🤣 😇

[andreab1997]

Anyway, I really like the new names. The old ones were very confusing

you know whom to blame 🤣 😇

yes, myself! xD

[andreab1997]

@andreab1997 please take a look to ekobox and tell me what you think ... I did some renaming (e.g. gen_theory.gen_theory_card -> theory_card.generate) so you would most likely need to adjust the n3fit fit side ...

also I'm not really convinced of providing default runcards from banana: 1. are we really sure we want to do this? (instead of sticking to our default-less scheme - and in NNPDF we always have full runcards) and 2. if still, I don't think we should inherit from banana: our default theory there is FFNS3 which is good for debugging, but stupid in production ...

I changed the names on evolven3fit and everything should work again

[felixhekhorn]

I changed the names on evolven3fit and everything should work again

Mmm that might have been premature ... you maybe want to stash that commit until this branch is released on main, which might take a while ...

[andreab1997]

I changed the names on evolven3fit and everything should work again

Mmm that might have been premature ... you maybe want to stash that commit until this branch is released on main, which might take a while ...

Oh I see. Yes I will do that

[felixhekhorn]

@alecandido maybe consider to merge this PR first before continuing on #105

[alecandido]

I reviewed half, and never run. I'll do both, but for the time being I submit current comments.

[alecandido]

For me this is fine, I'm going to merge and continue the development on the other branch.