Skip to content

QED anomalous dimensions#111

Merged
niclaurenti merged 73 commits into
developfrom
feature/qed-dglap
Apr 7, 2022
Merged

QED anomalous dimensions#111
niclaurenti merged 73 commits into
developfrom
feature/qed-dglap

Conversation

@felixhekhorn
Copy link
Copy Markdown
Collaborator

No description provided.

@felixhekhorn felixhekhorn added enhancement New feature or request physics new physics features labels Mar 30, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2022

Codecov Report

Merging #111 (246d84e) into develop (acd65aa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #111    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           36        38     +2     
  Lines         2575      2732   +157     
==========================================
+ Hits          2575      2732   +157     
Flag Coverage Δ
isobench 54.06% <34.81%> (-0.78%) ⬇️
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eko/anomalous_dimensions/__init__.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/aem1.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/aem2.py 100.00% <100.00%> (ø)
src/eko/anomalous_dimensions/as1aem1.py 100.00% <100.00%> (ø)
src/eko/constants.py 100.00% <100.00%> (ø)

Comment thread src/eko/anomalous_dimensions/as1aem1.py Outdated
Comment thread tests/eko/test_ad_as1aem1.py Outdated
Comment thread src/eko/anomalous_dimensions/as1aem1.py Outdated
Comment thread tests/eko/test_ad_as1aem1.py Outdated
@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

We need a section on "Sum Rules" in the docs, because it's a relevant theory ingredient and we're using all the time in testing.

fine - I guess we can add something under Mellin (as a special example); @niclaurenti can you please take care?

@niclaurenti
Copy link
Copy Markdown
Collaborator

@alecandido @felixhekhorn yes sure. I can take caro of it

Comment thread tests/eko/test_ad_aem2.py Outdated
@alecandido
Copy link
Copy Markdown
Collaborator

alecandido commented Apr 6, 2022

I haven't reviewed the expressions themselves, since this would require almost as much work as it has been done to implement them...
On this respect, I just trusts @niclaurenti

@niclaurenti
Copy link
Copy Markdown
Collaborator

I haven't reviewed the expressions themselves, since this would require almost as much work as it has been done to implement them...
On this respect, I just trusts @niclaurenti

I have reviewed multiple times but I'm trustful from the fact that they satisfy the sum rules.

@alecandido
Copy link
Copy Markdown
Collaborator

I haven't reviewed the expressions themselves, since this would require almost as much work as it has been done to implement them...
On this respect, I just trusts @niclaurenti

I have reviewed multiple times but I'm trustful from the fact that they satisfy the sum rules.

Me too, that's why I reviewed the tests. However, we had some bugs passing sum rules, e.g. normalizations, so I hope you took care enough in the overall implementation :D


that must be satisfied order by order in perturbation theory.


Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @niclaurenti

@niclaurenti
Copy link
Copy Markdown
Collaborator

@felixhekhorn @niclaurenti

We need a section on "Sum Rules" in the docs, because it's a relevant theory ingredient and we're using all the time in testing.

In particular, I was stupidly wondering "Why do we have multiple tests on momentum sum rules (for quark, gluon, and photon) if the conserved quantity is a single one?". I knew that being anomalous dimensions an operator (PDF in, PDF out) there should have been a clever way to break down on one of the two sides, but it took me quite some time (~5 min) in order to finally work out that I'm free to choose a border condition with only gluon, e.g., and the momentum should be preserved, but I'm ruling out all the other anomalous dimensions not having gluon on the right.

I'm not saying that is a very difficult topic that needs explanation, but explicit is better than implicit.

Do you think I should add this discussion or it's better to just give the sum rules

@alecandido
Copy link
Copy Markdown
Collaborator

Do you think I should add this discussion or it's better to just give the sum rules

If you wish, you can add a brief paragraph about why all these sum rules stem from a single integral relation, i.e. the proton momentum conservation. I leave the choice up to you.

Comment thread extras/uni-dglap/Makefile Outdated
Copy link
Copy Markdown
Collaborator

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually tempted to merge at this point, what do you think @felixhekhorn?

@niclaurenti
Copy link
Copy Markdown
Collaborator

@alecandido @felixhekhorn before merging I wanted to slightly modify the .tex file (for example writing Pqq-P+=Pps) and add a section that explains what has to be changed when passing to O(aem2)

@alecandido
Copy link
Copy Markdown
Collaborator

@niclaurenti you'll merge by yourself, so nothing will happen until you're ready (if you make any significant change to the package itself, ask again for review).

@niclaurenti niclaurenti merged commit b41dcf8 into develop Apr 7, 2022
@delete-merged-branch delete-merged-branch Bot deleted the feature/qed-dglap branch April 7, 2022 10:01
@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

I think it's fine (still maybe an explicit approval might have been good 😇 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request physics new physics features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants