Skip to content

Exclude N3LO matching from compilation#124

Merged
felixhekhorn merged 4 commits into
developfrom
feature/hide-n3lo
Jun 1, 2022
Merged

Exclude N3LO matching from compilation#124
felixhekhorn merged 4 commits into
developfrom
feature/hide-n3lo

Conversation

@felixhekhorn
Copy link
Copy Markdown
Collaborator

in order to prioritize #121 over #119 I suggest to do this quick fix here now and then later do the proper job in #123

@felixhekhorn felixhekhorn added the refactor Refactor code label May 31, 2022
@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2022

Codecov Report

Merging #124 (d1406ba) into develop (c316a2b) will decrease coverage by 4.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #124      +/-   ##
===========================================
- Coverage   100.00%   95.24%   -4.76%     
===========================================
  Files           67       67              
  Lines         3214     3197      -17     
===========================================
- Hits          3214     3045     -169     
- Misses           0      152     +152     
Flag Coverage Δ
isobench 52.34% <25.00%> (-1.38%) ⬇️
unittests 95.24% <100.00%> (-4.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eko/matching_conditions/operator_matrix_element.py 100.00% <100.00%> (ø)
src/eko/matching_conditions/as3/aHg.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/aHq.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/agg.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/agq.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/aqg.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/aqqNS.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/aqqPS.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/aggTF2.py 0.00% <0.00%> (-100.00%) ⬇️
src/eko/matching_conditions/as3/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 2 more

@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

We have to sacrifice coverage, but I'll promise to recover in #123 - let's close this and make a new release!

Comment thread src/eko/matching_conditions/operator_matrix_element.py
@felixhekhorn felixhekhorn merged commit 625318b into develop Jun 1, 2022
@delete-merged-branch delete-merged-branch Bot deleted the feature/hide-n3lo branch June 1, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants