N3LO singlet ad#137
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 78 78
Lines 3677 3721 +44
=========================================
+ Hits 3677 3721 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
alecandido
reviewed
Jul 15, 2022
Collaborator
alecandido
left a comment
alecandido
left a comment
There was a problem hiding this comment.
For me it is good enough, but maybe I'd wait for @felixhekhorn this time. It is hard to tell that your numbers make sense, but tests are sensible and passing, so far so good.
I just pointed out a few style remarks (mainly on docstrings).
Co-authored-by: Alessandro Candido <candido.ale@gmail.com>
felixhekhorn
requested changes
Jul 18, 2022
Collaborator
felixhekhorn
left a comment
felixhekhorn
left a comment
There was a problem hiding this comment.
- please make Li a rm name in TeX (either global or local)
- the parenthesis in the exponent here https://github.com/N3PDF/eko/blob/206cd3f38662f621b519cdcf7d7833c787f7f764/doc/source/theory/N3LO_ad.rst#L142 is definitely confusing
- https://github.com/N3PDF/eko/blob/206cd3f38662f621b519cdcf7d7833c787f7f764/doc/source/theory/N3LO_ad.rst#L8 an "analytical expression" I guess?
- https://github.com/N3PDF/eko/blob/206cd3f38662f621b519cdcf7d7833c787f7f764/doc/source/theory/N3LO_ad.rst#L21 ->
|NNLL| - https://github.com/N3PDF/eko/blob/206cd3f38662f621b519cdcf7d7833c787f7f764/doc/source/theory/N3LO_ad.rst#L5 ->
|DIS|(in case there is such an abbreviation - else you can inline here)
it may seem a lot of comments, but they are really mostly minor stuff about docs - but we just promised the other day we would put an effort ;-)
felixhekhorn
added
enhancement
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
Co-authored-by: Felix Hekhorn <felixhekhorn@users.noreply.github.com>
felixhekhorn
approved these changes
Jul 19, 2022
Collaborator
|
@giacomomagni just to repeat: #105 is actually built on top of this so we need to close this one first - which I believe we can |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete implementation of N3LO splitting functions