Fix LHA VFNS SV benchmark 2#219
Closed
felixhekhorn wants to merge 3 commits into
Closed
Conversation
Collaborator
I believe you tagged a random person 😂 |
Collaborator
However, as you know, I agree with everything but I am still not sure about the differences between scheme B and A. Maybe we can discuss tomorrow? |
giacomomagni
approved these changes
Mar 6, 2023
Collaborator
Author
|
Close in favor of #222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #215 - alternative implementation to #218
This PR is restoring the$\xi_F$ . The latter applies explicitly to the division of the masses on input (as done in #218) and that we don't feel comfortable with, and also to the former $\xi_F$ appearing (as suggested by @andreab1997 ).
v0.10benchmark (as #218 does), but avoids any division bysv_exponentiated_shift(that is deleted in this PR). There are, of course, in exchange, some multiplications withgridtoev_op) and 2) when doing this last step in scheme B the second and third argument toa1are the same again (so unlike scheme A where the two arguments are always different)