Invert ekomark-ekobox dependency#226
Merged
Merged
Conversation
felixhekhorn
added
refactor
felixhekhorn
commented
Mar 14, 2023
alecandido
approved these changes
Mar 14, 2023
Collaborator
alecandido
left a comment
alecandido
left a comment
There was a problem hiding this comment.
Since #225 is already approved, please merge before that one
Collaborator
giacomomagni
left a comment
giacomomagni
left a comment
There was a problem hiding this comment.
I'm fine with this.
I imagine this will break the dependency in many tools right?
Collaborator
Only those using |
andreab1997
approved these changes
Mar 17, 2023
Collaborator
|
Fine for me, I don't see anything harmful. For sure I will need to update something as @giacomomagni was saying but nothing too complicate I believe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122