fix Q2 grid in generate_block#280
Merged
Merged
Conversation
alecandido
approved these changes
Jun 5, 2023
Collaborator
alecandido
left a comment
alecandido
left a comment
There was a problem hiding this comment.
In principle, you should also take care that all the nf values are consistent. But never mind, I hope this will become simpler with partons, I'm working on it :)
Collaborator
Author
Let's hope this is not causing any problem for the time being. 😅 |
felixhekhorn
approved these changes
Jun 5, 2023
Collaborator
felixhekhorn
left a comment
felixhekhorn
left a comment
There was a problem hiding this comment.
I wonder if part of NNPDF/nnpdf#1746 should be done (or repeated) here
Collaborator
Don't waste too much effort on that, at least for a while more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the proper fix of NNPDF/nnpdf#1750