Change manipulate to act on Operator#292
Merged
Merged
Conversation
giacomomagni
approved these changes
Jul 31, 2023
Collaborator
Author
|
Since this is already breaking, I decided to put another breaking change on top: 3e2d12a drops the |
6 tasks
Collaborator
Author
this addresses the first item of #205 |
This was referenced Aug 8, 2024
This was referenced Oct 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
There is no need for additional iterators as
EKOis already providing all iterators needed. The only necessary change is to letmanipulateact onOperatorinstead of an wholeEKO.I guess, we consider this as a part of our public API, so this will trigger a new version. This might also have an effect on evolven3fit (cc @scarlehoff )
As a nice side effect, we also remove a bug discovered in #291 : when activating
plot_operatorsinekomarkwe were crashing, since there was amanipulateand this confused eko afterwards