Skip to content

Change manipulate to act on Operator#292

Merged
felixhekhorn merged 6 commits into
masterfrom
manipulate-operators
Aug 8, 2024
Merged

Change manipulate to act on Operator#292
felixhekhorn merged 6 commits into
masterfrom
manipulate-operators

Conversation

@felixhekhorn
Copy link
Copy Markdown
Collaborator

@felixhekhorn felixhekhorn commented Jul 24, 2023

Closes #203

There is no need for additional iterators as EKO is already providing all iterators needed. The only necessary change is to let manipulate act on Operator instead of an whole EKO.

I guess, we consider this as a part of our public API, so this will trigger a new version. This might also have an effect on evolven3fit (cc @scarlehoff )

As a nice side effect, we also remove a bug discovered in #291 : when activating plot_operators in ekomark we were crashing, since there was a manipulate and this confused eko afterwards

@felixhekhorn felixhekhorn added enhancement New feature or request output Output format and management labels Jul 24, 2023
Comment thread src/eko/io/manipulate.py Outdated
Comment thread src/ekomark/plots.py Outdated
Comment thread src/ekomark/plots.py
@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

Since this is already breaking, I decided to put another breaking change on top: 3e2d12a drops the Bases class, i.e. metadata does not know about different bases (x,pid) in input or output any longer, which is consistent with the main change introduced in this PR

@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

Since this is already breaking, I decided to put another breaking change on top: 3e2d12a drops the Bases class, i.e. metadata does not know about different bases (x,pid) in input or output any longer, which is consistent with the main change introduced in this PR

this addresses the first item of #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request output Output format and management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manipulate iterators

2 participants