Skip to content

Remove ev_op_iterations from truncated#459

Merged
felixhekhorn merged 3 commits into
masterfrom
truncated-iterations
Apr 29, 2025
Merged

Remove ev_op_iterations from truncated#459
felixhekhorn merged 3 commits into
masterfrom
truncated-iterations

Conversation

@felixhekhorn
Copy link
Copy Markdown
Collaborator

Closes #447

As a consequence ev_op_iterations also dropped from kernels.ns.dispatcher, i.e. in the non-singlet sector there is no iteration anywhere (since exact is exact). This triggers a few more changes on the testing side.

@felixhekhorn felixhekhorn added the bug Something isn't working label Apr 28, 2025
@giacomomagni
Copy link
Copy Markdown
Collaborator

giacomomagni commented Apr 28, 2025

This looks fine for me, the only other option I see is to hardcode the default value to 1 in the function signature. But also dropping it's fine!

@felixhekhorn
Copy link
Copy Markdown
Collaborator Author

This looks fine for me, the only other option I see is to hardcode the default value to 1 in the function signature. But also dropping it's fine!

I would prefer to remove it completely to also not confuse developers 🙃 - if you're happy please approve 😇

Since I just told our PhD students here how important documentation and as a part of that a Changelog is I finally started our Changelog here 🙈 thus: Closes #216

Note that in 0.15 there are so many changes that it was impossible for me to spell it out quickly (remember that all the long-standing PRs from back in the days (e.g. #295) got merged there)

@felixhekhorn felixhekhorn linked an issue Apr 29, 2025 that may be closed by this pull request
@felixhekhorn felixhekhorn merged commit a79174d into master Apr 29, 2025
7 checks passed
@felixhekhorn felixhekhorn deleted the truncated-iterations branch April 29, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use ev_op_iterations for "trucated" Add CHANGELOG/updated Documentation

2 participants