Remove ev_op_iterations from truncated#459
Merged
Merged
Conversation
Collaborator
|
This looks fine for me, the only other option I see is to hardcode the default value to 1 in the function signature. But also dropping it's fine! |
Collaborator
Author
I would prefer to remove it completely to also not confuse developers 🙃 - if you're happy please approve 😇 Since I just told our PhD students here how important documentation and as a part of that a Changelog is I finally started our Changelog here 🙈 thus: Closes #216 Note that in 0.15 there are so many changes that it was impossible for me to spell it out quickly (remember that all the long-standing PRs from back in the days (e.g. #295) got merged there) |
giacomomagni
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #447
As a consequence
ev_op_iterationsalso dropped fromkernels.ns.dispatcher, i.e. in the non-singlet sector there is no iteration anywhere (since exact is exact). This triggers a few more changes on the testing side.