Skip to content

QED - flavor basis#89

Merged
niclaurenti merged 28 commits into
developfrom
feature/qed
Feb 25, 2022
Merged

QED - flavor basis#89
niclaurenti merged 28 commits into
developfrom
feature/qed

Conversation

@niclaurenti
Copy link
Copy Markdown
Collaborator

@niclaurenti niclaurenti commented Feb 2, 2022

This will hold the QED implementation on flavor basis

@niclaurenti niclaurenti added the enhancement New feature or request label Feb 2, 2022
@niclaurenti niclaurenti self-assigned this Feb 2, 2022
@niclaurenti niclaurenti marked this pull request as draft February 2, 2022 11:35
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 2, 2022

Codecov Report

Merging #89 (4ebabac) into develop (c8b4538) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4ebabac differs from pull request most recent head 724b09f. Consider uploading reports for the commit 724b09f to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           develop       #89   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines         2431      2458   +27     
=========================================
+ Hits          2431      2458   +27     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/eko/anomalous_dimensions/lo.py 100.00% <100.00%> (ø)
src/eko/basis_rotation.py 100.00% <100.00%> (ø)
src/eko/beta.py 100.00% <100.00%> (ø)
src/eko/evolution_operator/flavors.py 100.00% <100.00%> (ø)
src/eko/evolution_operator/grid.py 100.00% <100.00%> (ø)
src/eko/matching_conditions/__init__.py 100.00% <100.00%> (ø)
src/eko/msbar_masses.py 100.00% <100.00%> (ø)

@giacomomagni giacomomagni added the physics new physics features label Feb 2, 2022
@giacomomagni giacomomagni linked an issue Feb 7, 2022 that may be closed by this pull request
@alecandido
Copy link
Copy Markdown
Collaborator

This is too generic, and it's not useful to try to do everything at once.

So decide what to address first (e.g. new basis, new anomalous dimensions,...) and let's try to target that thing first, and close this PR right after (if possible).

Otherwise you'll have to keep this open for months, it will become outdated (so you need to merge over and over develop), and much worse if something implemented here would be useful somewhere else, we'll need to cherry pick it.

@felixhekhorn
Copy link
Copy Markdown
Collaborator

Yes, yes - we do as we agreed: I simply closed the other one and we will merge this one as soon as we have something on the flavor basis

@felixhekhorn felixhekhorn changed the title QED QED - flavor basis Feb 11, 2022
niclaurenti and others added 7 commits February 11, 2022 17:09
* develop:
  Update Readme
  Update CONTRIBUTING
  Run pre-commit
  fix path in apfel bench
  Fix register and cfg in ekomark
  Recover test coverage to 100%
  Add CT18ZNNLO bench, update pre-commit
  Revert
  Init QED
Comment thread src/eko/basis_rotation.py Outdated
Comment thread src/eko/evolution_operator/flavors.py Outdated
Comment thread tests/test_basis_rotation.py Outdated
Comment thread tests/test_ev_op_flavors.py Outdated
Comment thread doc/source/theory/FlavorSpace.rst Outdated
Comment thread doc/source/theory/FlavorSpace.rst
Comment thread doc/source/theory/FlavorSpace.rst Outdated
@niclaurenti niclaurenti marked this pull request as ready for review February 17, 2022 13:03
Copy link
Copy Markdown
Collaborator

@giacomomagni giacomomagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side except a minor typo! Remember to merge develop here before merging this into develop.

Comment thread doc/source/theory/FlavorSpace.rst Outdated
Copy link
Copy Markdown
Collaborator

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things to fix, major changes are all ok :)

Comment thread doc/source/theory/FlavorSpace.rst Outdated
Comment thread doc/source/theory/FlavorSpace.rst Outdated
Comment thread doc/source/theory/FlavorSpace.rst Outdated
Comment thread doc/source/theory/FlavorSpace.rst Outdated
Comment thread doc/source/theory/FlavorSpace.rst Outdated
Comment thread src/eko/evolution_operator/flavors.py
Comment thread src/eko/evolution_operator/flavors.py Outdated
Comment thread src/eko/evolution_operator/grid.py
Comment thread doc/source/theory/FlavorSpace.rst
Copy link
Copy Markdown
Collaborator

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor and technical corrections

Comment thread doc/source/shared/abbreviations.rst Outdated
Comment thread doc/source/theory/FlavorSpace.rst Outdated
@niclaurenti niclaurenti merged commit 724b09f into develop Feb 25, 2022
@delete-merged-branch delete-merged-branch Bot deleted the feature/qed branch February 25, 2022 13:41
@alecandido alecandido mentioned this pull request Apr 5, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request physics new physics features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QED evolution LO

4 participants