should pseudata.py should use `fitting_data_dict`?

[scarlehoff]

I'm asking because pseudata.py is using common_data_reader

nnpdf/validphys2/src/validphys/pseudodata.py

Line 332 in 74d9183

all_exp_dicts = reader.common_data_reader(

which is not what n3fit uses any more.

(@siranipour pinging you since I noticed that while looking at #1285, but it's clearly not part of that PR so didn't want to add entropy there)

[siranipour]

Ah yes it absolutely should do. This will take some work, but hopefully will be easier for multiprocessing because we use only use python now as opposed to the unpickle-able swig objects. Will create a PR for this as it requires a bit of work

[scarlehoff]

Yeah sure, I didn't want to add it to the other PR because it is clearly a separate issue. I just noticed it by chance and realised that common_data_reader was not used at all during the fit.